Repository navigation
gh-114271: Clean Up _threadmodule.c - #116776
Closed
ericsnowcurrently wants to merge 14 commits into
Closed
ericsnowcurrently wants to merge 14 commits into
ericsnowcurrently wants to merge 14 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This strictly moves code around into sections and adjust some names, in the interest of making it obvious where to find code and where to add new code. This is partly motivated by gh-114839. There will be follow-up PRs in the near future that take advantage of this cleanup.
At the moment, this is mostly a demonstration of some of the cleanup that I think would help make gh-114839 easier to review. I'd actually split this up into two or three parts. My gut also tells me that there's probably one extra PR that could be split out of gh-114839, though I haven't quite identified what it would be.
CC @mpage