FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-113538: Allow client connections to be closed by CendioOssman · Pull Request #116784 · python/cpython · GitHub

/ cpython Public

gh-113538: Allow client connections to be closed - #116784

Merged
gvanrossum merged 15 commits into
python:mainfrom
CendioOssman:server_close
Mar 18, 2024
Merged

gh-113538: Allow client connections to be closed#116784
gvanrossum merged 15 commits into
python:mainfrom
CendioOssman:server_close

Conversation

CendioOssman commented Mar 14, 2024
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

This is a new attempt at #114432, with one additional commit to fix unreliably tests.


📚 Documentation preview 📚: https://cpython-previews--116784.org.readthedocs.build/

Give applications the option of more forcefully terminating client
connections for asyncio servers. Useful when terminating a service and
there is limited time to wait for clients to finish up their work.
We want to be able to detect if the application fails to keep track of
the transports, so we cannot keep them alive by using a hard reference.
The application might be waiting for all transports to close, so we need
to properly inform the server that this transport is done.
One could be made clearar, and the other is probably superfluous.
Try to get the streams and the kernel in to a more deterministic state
by specifying fixed buffering limits.
No possibly infinite loop. Instead ask the system how much buffer space
it has and fill that.
In case it takes some time, as we need access to the server side
stream objects to perform the test.

Copy link
Copy Markdown
Contributor Author

@gvanrossum, this should hopefully be more stable.

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, this looks like the right solution.

gvanrossum merged commit 4159644 into python:main Mar 18, 2024
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
…on#116784)

These give applications the option of more forcefully terminating client
connections for asyncio servers. Useful when terminating a service and
there is limited time to wait for clients to finish up their work.

This is a do-over with a test fix for pythongh-114432, which was reverted.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…on#116784)

These give applications the option of more forcefully terminating client
connections for asyncio servers. Useful when terminating a service and
there is limited time to wait for clients to finish up their work.

This is a do-over with a test fix for pythongh-114432, which was reverted.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…on#116784)

These give applications the option of more forcefully terminating client
connections for asyncio servers. Useful when terminating a service and
there is limited time to wait for clients to finish up their work.

This is a do-over with a test fix for pythongh-114432, which was reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL