FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116780: Fix `test_inspect` in `-OO` mode by sobolevn · Pull Request #116788 · python/cpython · GitHub

/ cpython Public

gh-116780: Fix test_inspect in -OO mode - #116788

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-116780
Mar 14, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-116780: Fix test_inspect in -OO mode#116788
sobolevn merged 1 commit into
python:mainfrom
sobolevn:issue-116780

Conversation

sobolevn commented Mar 14, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

GitHub suggested me @serhiy-storchaka and @hauntsaninja as reviewers, could you please take a look? :)

sobolevn added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 14, 2024
bedevere-app Bot mentioned this pull request Mar 14, 2024
Closed
bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 14, 2024
serhiy-storchaka approved these changes Mar 14, 2024
View reviewed changes

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

sobolevn merged commit f20dfb7 into python:main Mar 14, 2024

miss-islington-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

sobolevn commented Mar 14, 2024

Copy link
Copy Markdown
Member Author

Thank you! 👍

miss-islington-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f20dfb7569a769da50cd75f4932b9abe78e55d75 3.12

miss-islington-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f20dfb7569a769da50cd75f4932b9abe78e55d75 3.11

sobolevn added a commit to sobolevn/cpython that referenced this pull request Mar 14, 2024
[3.12] pythongh-116780: Fix test_inspect in -OO mode (pythonGH-11…
303c3db 
…6788)

bedevere-app Bot commented Mar 14, 2024

Copy link
Copy Markdown

GH-116799 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 14, 2024
sobolevn added a commit that referenced this pull request Mar 17, 2024
[3.12] gh-116780: Fix test_inspect in -OO mode (GH-116788) (#116799)
2dbc77e
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
e9cdbfc
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
430442e
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-116780: Fix test_inspect in -OO mode (python#116788)
2227362
zware removed the needs backport to 3.11 only security fixes label Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka approved these changes
hauntsaninja Awaiting requested review from hauntsaninja

Assignees

sobolevn

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL