| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Back | FazBrowse Home | New Git URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityI still think that format is a property of the oparg, not the instruction itself. It is never correct to execute an instruction with the wrong format for its oparg, so it feels wrong to provide it separately here and allow them to drift out of sync (which I just spent a lot of time debugging yesterday). Bonus points for not needing a bitfield.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low QualityIt may never correct to execute an instruction with the wrong format, but this is primarily a format for optimization.
The "target" format is the correct format for all instructions during optimization.
If we care about tier 2 interpreter performance, we will want a different format for execution anyway.
What we could do is use different formats before and after prepare_for_execution, but I'd rather leave that for another PR.
What's wrong with bitfields?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.