Repository navigation
CI: Only test free-threading with faster macOS M1 - #116814
Merged
ambv merged 1 commit intoMar 14, 2024
Merged
ambv merged 1 commit into
ambv merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hugovk
commented
Mar 14, 2024
Comment thread
.github/workflows/reusable-macos.yml
| "macos-14", # M1 | ||
| "macos-13", # Intel | ||
| ] | ||
| os: ${{fromJson(inputs.os-matrix)}} |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
We can't pass arrays into reusable workflows, only strings, booleans or numbers. So we pass the array as a string, then use fromJson to convert the string into a list.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
ambv
enabled auto-merge (squash)
March 14, 2024 14:14
vstinner
pushed a commit
to vstinner/cpython
that referenced
this pull request
Mar 20, 2024
Only test free-threading with faster macOS M1
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
Only test free-threading with faster macOS M1
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Only test free-threading with faster macOS M1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to only have a single macOS Intel job in the CI.
But we have recently quadrupled it:
Plus we occasionally have a couple testing the JIT, but they only trigger when relevant files are modified.
Unfortunately, we're limited to a maximum of 5 concurrent macOS jobs:
This means at busy times, jobs can be queued for a long time waiting for free macOS runners. In the meantime, the other jobs have finished, but we need to sit around until one of the five runners becomes free.
We've run in to this once per week for the last three weeks, during European evening/US daytime.
To mitigate, let's remove some macOS jobs.
We can't remove them from the regular build, because they're needed to maintain PEP 11's Tier 1 support. So let's start by removing one macOS test job for the free-threading build.
Here's macOS job times for five recent builds. macos-13 is Intel, macOS-14 is M1.
M1 is much faster (~8 mins), so let's remove the slower free-threading Intel job (~20 mins).
If the problem persists, we can remove the free-threading M1 job as well.
And hopefully GitHub will be able to increase the number of concurrent macOS jobs in the future, especially as the free-threading work matures. 🤞