FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116869: Enable test_cext and test_cppext on Free Threading build by vstinner · Pull Request #116973 · python/cpython · GitHub

Repository navigation

gh-116869: Enable test_cext and test_cppext on Free Threading build - #116973

Merged
vstinner merged 2 commits into
python:mainfrom
vstinner:enable_test_cext_gil_disabled
Mar 18, 2024
Merged

vstinner merged 2 commits into
python:mainfrom
vstinner:enable_test_cext_gil_disabled

Conversation

vstinner commented Mar 18, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators to the class.

Copy link
Copy Markdown
Contributor

!buildbot nogil

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 98ff887 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • AMD64 Ubuntu NoGIL PR
  • x86-64 MacOS Intel NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR

Copy link
Copy Markdown
Member Author

!buildbot nogil

Thanks, I planned to do it, but waited for the first basic checks to make sure that I didn't mess up anything :-)

Comment thread Lib/test/test_cext/__init__.py Outdated
Comment on lines +21 to +23
@unittest.skipIf(
'-fsanitize' in (sysconfig.get_config_var('PY_CFLAGS') or ''),
'test does not work with analyzing builds')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

You can probably use support.skip_if_sanitizer(...) here

…uild

Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators
to the class.
vstinner force-pushed the enable_test_cext_gil_disabled branch from 98ff887 to 1a3a98b Compare March 18, 2024 22:38
vstinner enabled auto-merge (squash) March 18, 2024 22:38
vstinner disabled auto-merge March 18, 2024 22:38

Copy link
Copy Markdown
Member Author

Oh, I had to rebase this PR to retrieve the WASI build fix.

vstinner enabled auto-merge (squash) March 18, 2024 22:45
vstinner merged commit 1d82a41 into python:main Mar 18, 2024
vstinner deleted the enable_test_cext_gil_disabled branch March 18, 2024 23:14
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
…uild (python#116973)

Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators
to the class. Use support.check_sanitizer()
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
…uild (python#116973)

Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators
to the class. Use support.check_sanitizer()
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…uild (python#116973)

Remove the "if Py_GIL_DISABLED" skip and move all "skip" decorators
to the class. Use support.check_sanitizer()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL