| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
This is only marked Draft because I didn't want to ping 29 other people for review. Can that be stopped? |
Sorry, something went wrong.
I don't know of a way of avoiding that, unfortunately... It's not possible for me to deselect any of the codeowners from the list of people who are going to be requested for review. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM, thanks! I agree that these are distracting for readers, and serve no purpose.
While I agree with @CAM-Gerlach's comments on Discord that a Sphinx extension might be a cleaner way of fixing this, I'm personally happy to merge this unless somebody wants to volunteer to actually do that. I think we should prioritise the experience for readers of the docs, and this PR improves the experience of reading the docs.
Sorry, something went wrong.
|
Since I don't want to ping 29 code owners, and am a little bit interested in learning about Sphinx internals, let's wait on this to see how the CAM+Ned tag team manages on tweaking Sphinx. |
Sorry, something went wrong.
|
Everyone: I know this might ping many people. My apologies. The changes were auto-created across all of the module pages. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM.
How we did not notice this earlier?
Sorry, something went wrong.
|
Thanks @nedbat for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Sorry, something went wrong.
…ythonGH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
…ythonGH-117099) (cherry picked from commit bcb435e) Co-authored-by: Ned Batchelder <ned@nedbatchelder.com>
|
GH-118790 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
|
GH-118791 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
The :mod: role used in the title of module pages turns into a link, but the link is to the same page. That's distracting and unhelpful. This uses the ! prefix to instruct Sphinx to not make a link.
This was done with this thrown-together program:
📚 Documentation preview 📚: https://cpython-previews--117099.org.readthedocs.build/