FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-117122: Fix pystats after incremental GC changes by mdboom · Pull Request #117123 · python/cpython · GitHub

/ cpython Public

gh-117122: Fix pystats after incremental GC changes - #117123

Closed
mdboom wants to merge 2 commits into
python:mainfrom
mdboom:pystats-gc
ConversationCommits (2)ChecksFiles changed
Closed

gh-117122: Fix pystats after incremental GC changes#117123
mdboom wants to merge 2 commits into
python:mainfrom
mdboom:pystats-gc

Conversation

mdboom commented Mar 21, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Mar 21, 2024
Closed
mdboom commented Mar 21, 2024
View reviewed changes
Comment thread Python/gc.c
mdboom commented Mar 21, 2024
View reviewed changes
Comment thread Python/gc.c
increment_size += expand_region_transitively_reachable(&increment, gc, gcstate);
}
GC_STAT_ADD(1, objects_queued, region_size);
GC_STAT_ADD(1, objects_queued, increment_size);

mdboom Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I don't know if this is correct, but region_size doesn't exist.

markshannon Mar 21, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?

mdboom requested a review from markshannon March 21, 2024 13:47
markshannon reviewed Mar 21, 2024
View reviewed changes

markshannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is going to conflict with #117120.
Once that's in, I'll review this properly.

Comment thread Python/gc.c
increment_size += expand_region_transitively_reachable(&increment, gc, gcstate);
}
GC_STAT_ADD(1, objects_queued, region_size);
GC_STAT_ADD(1, objects_queued, increment_size);

markshannon Mar 21, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?

markshannon commented Mar 21, 2024

Copy link
Copy Markdown
Member

Actually, don't worry about the merge conflict. I can fix it in my PR

mdboom commented Mar 21, 2024

Copy link
Copy Markdown
Contributor Author

I'm not sure if this make sense anymore. Maybe just drop the "queued" stat?

I leave that to you, but this stat is new as of #116206 (it's just that it never compiled).

mdboom mentioned this pull request Mar 21, 2024
Merged
mdboom closed this Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

markshannon markshannon left review comments

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL