FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] bpo-35537: Fix function name in os.posix_spawnp() errors by vstinner · Pull Request #11719 · python/cpython · GitHub

/ cpython Public

[WIP] bpo-35537: Fix function name in os.posix_spawnp() errors - #11719

Merged
vstinner merged 1 commit into
python:masterfrom
vstinner:spawnp_func_name
Feb 1, 2019
ConversationCommits (1)ChecksFiles changed
Merged

[WIP] bpo-35537: Fix function name in os.posix_spawnp() errors#11719
vstinner merged 1 commit into
python:masterfrom
vstinner:spawnp_func_name

Conversation

vstinner commented Feb 1, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

vstinner commented Feb 1, 2019

Copy link
Copy Markdown
Member Author

I marked the PR as WIP because I noticed that test_posix fails even without my PR: see PR #11718.

vstinner mentioned this pull request Feb 1, 2019
Merged

vstinner commented Feb 1, 2019

Copy link
Copy Markdown
Member Author

I merged PR #11718. I rebased this PR on top of it.

@izbyshev, @nanjekyejoannah: Would you mind to check that the function name is properly passed to all os.posix_spawn() and os.posix_spawnp() error messages in my PR?

pablogsal commented Feb 1, 2019

Copy link
Copy Markdown
Member

@vstinner I opened https://bugs.python.org/issue35876 after seeing the buildbot failures to track the failing test fixes.

nanjekyejoannah commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

@vstinner the function name passing lgtm. I haven't identified anything contrary.

vstinner merged commit 325e4ba into python:master Feb 1, 2019
vstinner deleted the spawnp_func_name branch February 1, 2019 14:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
izbyshev izbyshev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL