gh-116622: Test updates for Android - #117299
Conversation
Sorry, something went wrong.
| @unittest.skipIf( | ||
| sys.platform.startswith(("freebsd", "wasi")) | ||
| or (sys.platform == "android" and platform.machine() == "x86_64"), | ||
| f"this platform doesn't implement IEE 754-2008 properly") | ||
| def test_fma_zero_result(self): |
There was a problem hiding this comment.
See discussion at #116667 (comment).
Sorry, something went wrong.
|
@erlend-aasland: Are you able to review this PR? It's a continuation of the previous Android test updates from #115918. |
Sorry, something went wrong.
erlend-aasland
left a comment
There was a problem hiding this comment.
LGTM, with some nits. BTW, last time I checked, the sys.platform.startswith idiom was still recommended practice. I'd prefer if we could follow that.
Sorry, something went wrong.
| # The Android testbed redirects the native stdout to a pipe, | ||
| # which returns a different error code. | ||
| known_errnos.append(errno.EACCES) | ||
| if (sys.platform == "win32") or (e.errno in known_errnos): |
There was a problem hiding this comment.
The parentheses are not needed.
Sorry, something went wrong.
Fixed.
I actually updated the sys.platform documentation in #116215 (comment) to limit this recommendation to FreeBSD. Ever since Python 3.3, all other PEP 11-supported platforms have returned a fixed string without a version number. |
Sorry, something went wrong.
|
@mhsmith, thanks for the heads-up, I missed that docs update (and I've must have looked at the 3.12 docs). Perhaps we should consider backporting that doc patch. |
Sorry, something went wrong.
- re-enable test_fcntl_64_bit on Linux aarch64, but disable it on all Android ABIs - use support.setswitchinterval in all relevant tests - skip test_fma_zero_result on Android x86_64 - accept EACCES when calling os.get_terminal_size on Android
This PR fixes various Android test issues which I've discovered over the last few weeks.