Repository navigation
gh-117381: Fix error message for ntpath.commonpath - #117382
Merged
serhiy-storchaka merged 5 commits intoApr 3, 2024
Merged
serhiy-storchaka merged 5 commits into
serhiy-storchaka merged 5 commits into
Conversation
nineteendo
marked this pull request as ready for review
March 29, 2024 21:50
Copy link
Copy Markdown
Member
|
I think maybe we need a test to ensure the expected error will be raised. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
There are now assertRaisesRegex tests for all these cases:
Created with https://csacademy.com/app/graph_editor (mermaid can't connect horizontally): D:/foo C:/foo
D:/foo C:foo
D:foo C:/foo
D:foo C:foo
C:/foo C:foo
C:/foo /foo
C:/foo foo
C:foo /foo
C:foo foo
/foo foo
|
Sorry, something went wrong.
Comment thread
Lib/test/test_ntpath.py
Outdated
Comment thread
Lib/test/test_ntpath.py
Outdated
serhiy-storchaka
approved these changes
Apr 3, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.