gh-117398: datetime: Support per-interpreter C-API - #117399
Closed
neonene wants to merge 7 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
neonene
requested review from
abalkin,
ericsnowcurrently and
pganssle
as code owners
March 31, 2024 02:45
neonene
marked this pull request as draft
March 31, 2024 04:33
Eclips4
reviewed
Mar 31, 2024
Comment thread
Modules/_datetimemodule.c
| PyObject *capsule = PyCapsule_New(capi, PyDateTime_CAPSULE_NAME, | ||
| datetime_destructor); | ||
| set_datetime_capi(st); | ||
| PyObject *capsule = PyCapsule_New(&st->capi, PyDateTime_CAPSULE_NAME, NULL); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Can you explain why do you pass a NULL as a capsule destructor?
Is there any reason not to have destructor for this capsule?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
In this case, the capsule just views a memory allocated and freed by the moduleobject.
cpython/Objects/moduleobject.c
Lines 739 to 740 in bfc57d4
Sorry, something went wrong.
Eclips4
reviewed
Mar 31, 2024
Comment thread
Modules/_datetimemodule.c
Outdated
Copy link
Copy Markdown
Contributor
Author
|
No futher experiment here. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
On second thought, exposing a module state to a user is dangerous. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This places C-API structure on a module state, which can be accessed through PyInterpreterState or a capsule.
Doc: