gh-117398: datetime: Make use of C-API capsules for sub-interpreters - #117413
Closed
neonene wants to merge 16 commits into
Closed
gh-117398: datetime: Make use of C-API capsules for sub-interpreters#117413neonene wants to merge 16 commits into
neonene wants to merge 16 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
neonene
requested review from
abalkin,
ericsnowcurrently,
gvanrossum,
markshannon and
pganssle
as code owners
April 1, 2024 05:08
Eclips4
reviewed
Apr 1, 2024
Comment thread
Include/datetime.h
Outdated
Eclips4
reviewed
Apr 1, 2024
Comment thread
Include/datetime.h
Outdated
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Copy link
Copy Markdown
Member
|
I'm especially interested to know what @pganssle thinks. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I have made this the same as #118357 except that this PR caches capi-pointers in the global C array rather than PyInterpreterState. One subinterpreter can use the global variable for now, so PyCapsule_Import will be called when multiple subinterpreters use the _datetime module at the same time. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow sub-interpreters to access their C-API by calling PyCapsule_Import function every time. Performance could be recovered by client's local caching. The _zoneinfo extension could also improve a few C-API accesses, if necessary.
UPDATE: Tuned for a sub-interpreter: #117413 (comment)
cc @erlend-aasland @ericsnowcurrently