Repository navigation
gh-117394: Speed up os.path.ismount() on Posix - #117447
Merged
serhiy-storchaka merged 2 commits intoApr 17, 2024
Merged
serhiy-storchaka merged 2 commits into
serhiy-storchaka merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
It is now 2-3 times faster if the user has permissions.
nineteendo
reviewed
Apr 2, 2024
Comment thread
Lib/posixpath.py
serhiy-storchaka
commented
Apr 2, 2024
Comment thread
Lib/posixpath.py
Outdated
Copy link
Copy Markdown
Contributor
|
Benchmark: # test.sh
echo "relative" && python -m timeit -s "import before.posixpath" "before.posixpath.ismount('.')" && python -m timeit -s "import after.posixpath" "after.posixpath.ismount('.')"
echo "absolute" && python -m timeit -s "import before.posixpath" "before.posixpath.ismount('/Volumes/2GB_001')" && python -m timeit -s "import after.posixpath" "after.posixpath.ismount('/Volumes/2GB_001')"
echo "no permission" && python -m timeit -s "import before.posixpath" "before.posixpath.ismount('/Users/wannes/path-picker/permission-test/dirs/666')" && python -m timeit -s "import after.posixpath" "after.posixpath.ismount('/Users/wannes/path-picker/permission-test/dirs/666')"relative
10000 loops, best of 5: 27.3 usec per loop # before
50000 loops, best of 5: 8.25 usec per loop # after
# -> 3.29x faster
absolute
20000 loops, best of 5: 19.7 usec per loop # before
50000 loops, best of 5: 8.21 usec per loop # after
# -> 2.40x faster
no permission
5000 loops, best of 5: 41.2 usec per loop # before
5000 loops, best of 5: 48.5 usec per loop # after
# -> 1.18x slower
|
Sorry, something went wrong.
nineteendo
reviewed
Apr 3, 2024
Comment thread
Lib/posixpath.py
nineteendo
approved these changes
Apr 3, 2024
Copy link
Copy Markdown
Contributor
|
@erlend-aasland, could you review this? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looks good to me, but I'm not sure if it worth the added maintenance cost to optimise this. I mean, how often is the ismount API used? I'll leave it for Serhiy to decide. |
Sorry, something went wrong.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
It is now 2-3 times faster if the user has permissions.
bandrel
added a commit
to trustedsec/hate_crack
that referenced
this pull request
Oct 2, 2026
…e stability) readline completer delimiters on macOS libedit must NOT include \n (newline). When newline is a delimiter and the prompt contains embedded newlines (which 26+ input locations in hate_crack do), libedit's cursor position tracking becomes unstable during completion, causing backspace to be ignored or behave unexpectedly. Removing \n from readline.set_completer_delims() in both attacks.py and main.py restores stable backspace behavior while maintaining tab completion. Fixes: Random inability to backspace in menu prompts Ref: python/cpython#117447 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is now 2-3 times faster if the user has permissions.