FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-117267: Ensure DirEntry.stat().st_ctime still contains creation time during deprecation period (GH-117354) by miss-islington · Pull Request #117525 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.12] gh-117267: Ensure DirEntry.stat().st_ctime still contains creation time during deprecation period (GH-117354) #117525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zooba merged 1 commit into from
Apr 3, 2024
Conversation 0 Commits 1 Checks 0 Files changed
Merged

[3.12] gh-117267: Ensure DirEntry.stat().st_ctime still contains creation time during deprecation period (GH-117354) #117525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .c  (1) .rst  (1) All 2 file types selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Windows/2024-03-28-22-12-00.gh-issue-117267.K_tki1.rst
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Ensure ``DirEntry.stat().st_ctime`` behaves consistently with
:func:`os.stat` during the deprecation period of ``st_ctime`` by containing
the same value as ``st_birthtime``. After the deprecation period,
``st_ctime`` will be the metadata change time (or unavailable through
``DirEntry``), and only ``st_birthtime`` will contain the creation time.
4 changes: 4 additions & 0 deletions Modules/posixmodule.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -15050,6 +15050,10 @@ DirEntry_from_find_data(PyObject *module, path_t *path, WIN32_FIND_DATAW *dataW)
find_data_to_file_info(dataW, &file_info, &reparse_tag);
_Py_attribute_data_to_stat(&file_info, reparse_tag, NULL, NULL, &entry->win32_lstat);

/* ctime is only deprecated from 3.12, so we copy birthtime across */
entry->win32_lstat.st_ctime = entry->win32_lstat.st_birthtime;
entry->win32_lstat.st_ctime_nsec = entry->win32_lstat.st_birthtime_nsec;

return (PyObject *)entry;

error:
Expand Down
Back | FazBrowse Home | New Git URL