gh-117531: Unblock getters after non-immediate queue shutdown - #117532
Merged
gvanrossum merged 10 commits intoApr 10, 2024
Merged
gh-117531: Unblock getters after non-immediate queue shutdown#117532gvanrossum merged 10 commits into
gvanrossum merged 10 commits into
Conversation
EpicWink
force-pushed
the
queue-shutdown-unblock-get
branch
from
8bb6fae to
5d490b3
Compare
April 4, 2024 02:09
rhettinger
removed their request for review
April 4, 2024 02:16
YvesDup
reviewed
Apr 4, 2024
Comment thread
Lib/test/test_queue.py
Outdated
YvesDup
reviewed
Apr 4, 2024
Comment thread
Lib/test/test_queue.py
Outdated
Copy link
Copy Markdown
Contributor
|
Regarding my last comments, docstring of shutdown method (and related documentation - I didn't check) must be modified about 'blocked callers'. |
Sorry, something went wrong.
YvesDup
reviewed
Apr 8, 2024
Comment thread
Lib/queue.py
Copy link
Copy Markdown
Contributor
|
I approved the last commits and I'm waiting for the last comment to be approve (or not). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I approve |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@gvanrossum Sorry, I forget to tell you that I've approved |
Sorry, something went wrong.
gvanrossum
approved these changes
Apr 10, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ython#117532) (This is a small tweak of the original pythongh-104750 which added shutdown.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.