FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-117566: fix IPv6Address.is_loopback for IPv4-mapped loopbacks by paravoid · Pull Request #117567 · python/cpython · GitHub

/ cpython Public

gh-117566: fix IPv6Address.is_loopback for IPv4-mapped loopbacks - #117567

Merged
encukou merged 2 commits into
python:mainfrom
paravoid:ipv4-mapped-loopback
Apr 25, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-117566: fix IPv6Address.is_loopback for IPv4-mapped loopbacks#117567
encukou merged 2 commits into
python:mainfrom
paravoid:ipv4-mapped-loopback

Conversation

paravoid commented Apr 5, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

While properties like IPv6Address.is_private account for IPv4-mapped IPv6 addresses, such as for example:

>>> ipaddress.ip_address("192.168.0.1").is_private
True
>>> ipaddress.ip_address("::ffff:192.168.0.1").is_private
True

...the same doesn't currently apply to the is_loopback property:

>>> ipaddress.ip_address("127.0.0.1").is_loopback
True
>>> ipaddress.ip_address("::ffff:127.0.0.1").is_loopback
False

At minimum, this inconsistency between different properties is counter-intuitive. Moreover, ::ffff:127.0.0.0/104 is for all intents and purposes a loopback address, and should be treated as such.

ghost commented Apr 5, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

bedevere-app Bot mentioned this pull request Apr 5, 2024
Closed

bedevere-app Bot commented Apr 5, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

paravoid force-pushed the ipv4-mapped-loopback branch from d0967df to e07c72b Compare April 5, 2024 12:51

paravoid commented Apr 23, 2024

Copy link
Copy Markdown
Contributor Author

@encukou @gpshead, I noticed that you've reviewed this area of code before, and hopefully this is going to be a trivial one for you :) (Apologies beforehand if the direct ping is undesired/spammy, not sure about the etiquette here!)

encukou commented Apr 23, 2024

Copy link
Copy Markdown
Member

Thanks for the fix.
Could you add a simple test as well?

pythongh-117566: fix IPv6Address.is_loopback for IPv4-mapped loopbacks
35c5efb 
While properties like IPv6Address.is_private account for IPv4-mapped
IPv6 addresses, such as for example:

    >>> ipaddress.ip_address("192.168.0.1").is_private
    True
    >>> ipaddress.ip_address("::ffff:192.168.0.1").is_private
    True
...the same doesn't currently apply to the is_loopback property:
    >>> ipaddress.ip_address("127.0.0.1").is_loopback
    True
    >>> ipaddress.ip_address("::ffff:127.0.0.1").is_loopback
    False

At minimum, this inconsistency between different properties is
counter-intuitive. Moreover, ::ffff:127.0.0.0/104 is for all intents and
purposes a loopback address, and should be treated as such.
paravoid force-pushed the ipv4-mapped-loopback branch from e07c72b to 35c5efb Compare April 25, 2024 11:15

paravoid commented Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the fix. Could you add a simple test as well?

Thanks for the quick review! That's a good point, I added tests now as well.

encukou reviewed Apr 25, 2024
View reviewed changes
Comment thread Lib/test/test_ipaddress.py Outdated
encukou approved these changes Apr 25, 2024
View reviewed changes

encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thank you!

encukou enabled auto-merge (squash) April 25, 2024 14:46
encukou added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Apr 25, 2024
encukou merged commit fb7f79b into python:main Apr 25, 2024
paravoid deleted the ipv4-mapped-loopback branch April 25, 2024 15:35

paravoid commented Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

Looks good, thank you!

Thank you so much for the super quick turnaround! Is this something that should/could also make it to 3.12.x or does it sit outside of the stable bugfix policies?

encukou added the needs backport to 3.12 only security fixes label Apr 29, 2024

miss-islington-app Bot commented Apr 29, 2024

Copy link
Copy Markdown

Thanks @paravoid for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 29, 2024
pythongh-117566: fix IPv6Address.is_loopback for IPv4-mapped loopbacks (
4ab6c58 
pythonGH-117567)

While properties like IPv6Address.is_private account for IPv4-mapped
IPv6 addresses, such as for example:

    >>> ipaddress.ip_address("192.168.0.1").is_private
    True
    >>> ipaddress.ip_address("::ffff:192.168.0.1").is_private
    True
...the same doesn't currently apply to the is_loopback property:
    >>> ipaddress.ip_address("127.0.0.1").is_loopback
    True
    >>> ipaddress.ip_address("::ffff:127.0.0.1").is_loopback
    False

At minimum, this inconsistency between different properties is
counter-intuitive. Moreover, ::ffff:127.0.0.0/104 is for all intents and
purposes a loopback address, and should be treated as such.
(cherry picked from commit fb7f79b)

Co-authored-by: Faidon Liambotis <paravoid@debian.org>

bedevere-app Bot commented Apr 29, 2024

Copy link
Copy Markdown

GH-118391 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 29, 2024
encukou pushed a commit that referenced this pull request Apr 29, 2024
[3.12] gh-117566: fix IPv6Address.is_loopback for IPv4-mapped loopbac…
3989894 
…ks (GH-117567) (GH-118391)

gh-117566: fix IPv6Address.is_loopback for IPv4-mapped loopbacks (GH-117567)

While properties like IPv6Address.is_private account for IPv4-mapped
IPv6 addresses, such as for example:

    >>> ipaddress.ip_address("192.168.0.1").is_private
    True
    >>> ipaddress.ip_address("::ffff:192.168.0.1").is_private
    True
...the same doesn't currently apply to the is_loopback property:
    >>> ipaddress.ip_address("127.0.0.1").is_loopback
    True
    >>> ipaddress.ip_address("::ffff:127.0.0.1").is_loopback
    False

At minimum, this inconsistency between different properties is
counter-intuitive. Moreover, ::ffff:127.0.0.0/104 is for all intents and
purposes a loopback address, and should be treated as such.

(cherry picked from commit fb7f79b)

Co-authored-by: Faidon Liambotis <paravoid@debian.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

encukou encukou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL