Repository navigation
gh-117431: Argument Clinic: copy forced text signature when cloning - #117591
Merged
erlend-aasland merged 6 commits intoApr 10, 2024
Merged
erlend-aasland merged 6 commits into
erlend-aasland merged 6 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
erlend-aasland
marked this pull request as ready for review
April 6, 2024 20:46
vstinner
approved these changes
Apr 8, 2024
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. You can ignore my suggestion on using a non-empty docstring.
Sorry, something went wrong.
Comment thread
Lib/test/test_clinic.py
Comment thread
Tools/clinic/libclinic/dsl_parser.py
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, @vstinner. I expanded the tests. |
Sorry, something went wrong.
serhiy-storchaka
approved these changes
Apr 9, 2024
serhiy-storchaka
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks for the review, Serhiy! I'll land this tomorrow. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #117590