Repository navigation
gh-111726: Cleanup test files after running sqlite3 doctest - #117604
Merged
erlend-aasland merged 1 commit intoApr 8, 2024
Merged
erlend-aasland merged 1 commit into
erlend-aasland merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I think it is ok to clean them up in a single testcleanup at the end. BTW, see also: I think we should merge this first, as #111730 grew in complexity. |
Sorry, something went wrong.
erlend-aasland
approved these changes
Apr 8, 2024
erlend-aasland
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thank you so much!
Sorry, something went wrong.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 8, 2024
…thonGH-117604) Remove all temporary databases in a dedicated 'testcleanup' step at the end of the file. (cherry picked from commit a453f5e) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Copy Markdown
|
GH-117622 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
erlend-aasland
added a commit
to sobolevn/cpython
that referenced
this pull request
Apr 8, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…thon#117604) Remove all temporary databases in a dedicated 'testcleanup' step at the end of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running make -C Doc/ PYTHON=../python.exe doctest on main I'm left with some untracked test files:
We don't need them, let's delete them after the doctest.
I did it as a single testcleanup block at the end of the file. Is this okay or should I make a few localised blocks near where each file is created?
📚 Documentation preview 📚: https://cpython-previews--117604.org.readthedocs.build/