Repository navigation
gh-117639: Special case for "" & "." in posixpath.abspath() - #117640
Closed
nineteendo wants to merge 3 commits into
Closed
nineteendo wants to merge 3 commits into
nineteendo wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
nineteendo
marked this pull request as ready for review
April 8, 2024 15:05
Comment thread
Lib/posixpath.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark:
abspath() 20000 loops, best of 5: 17.7 usec per loop # before 20000 loops, best of 5: 17.4 usec per loop # after # -> 1.02x faster abspath('.') 20000 loops, best of 5: 18.1 usec per loop # before 20000 loops, best of 5: 15.7 usec per loop # after # -> 1.15x faster (for '' & '.') relpath() 10000 loops, best of 5: 39.4 usec per loop # before 10000 loops, best of 5: 39.8 usec per loop # after # -> no difference relpath('foo') 5000 loops, best of 5: 38.9 usec per loop # before 10000 loops, best of 5: 37.4 usec per loop # after # -> 1.04x faster (for a single relative path) relpath('/') 10000 loops, best of 5: 22 usec per loop # before 10000 loops, best of 5: 20.7 usec per loop # after # -> 1.06x faster (for a single absolute path)