FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-112844: Fix xz CPE identifier by sethmlarson · Pull Request #117656 · python/cpython · GitHub

/ cpython Public

gh-112844: Fix xz CPE identifier - #117656

Merged
zooba merged 1 commit into
python:mainfrom
sethmlarson:xz-cpe
Apr 16, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-112844: Fix xz CPE identifier#117656
zooba merged 1 commit into
python:mainfrom
sethmlarson:xz-cpe

Conversation

sethmlarson commented Apr 8, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Previous CPE identifier was for an xz Go package, not for the upstream package (isn't CPE fun?) Confirmed that this CPE works to detect the recent backdoor CVE by manually faking the metadata for 5.6.1 and running Grype. Will need a backport to 3.12 as well.

sethmlarson added type-security A security issue skip news 3.12 only security fixes labels Apr 8, 2024
sethmlarson requested a review from zooba April 8, 2024 22:01
bedevere-app Bot mentioned this pull request Apr 8, 2024
Closed

zooba commented Apr 9, 2024

Copy link
Copy Markdown
Member

LGTM. How do we interpret that reference? Since tukaani isn't literally the name of the GitHub org, I'm not quite sure where I should look to find it.

sethmlarson commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

@zooba You have to go the the CVE Dictionary and search it or download the entire dataset. They helpfully disallow queries under 3 characters so "xz" won't do, and this caused me to not find the right CPE. Searching for "xz tukaani" lets you find the right one and confirm the linkage to CVE-2024-3094 (xz-utils backdoor).

zooba commented Apr 9, 2024

Copy link
Copy Markdown
Member

I just searched the whole string as shown in the file and it found the right one (not the one with the most recent CVE, of course). So that's good to know.

zooba merged commit d70ee13 into python:main Apr 16, 2024
zooba added the needs backport to 3.12 only security fixes label Apr 16, 2024

miss-islington-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

Thanks @sethmlarson for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 16, 2024
pythongh-112844: Fix xz CPE identifier (pythonGH-117656)
21c1366 
(cherry picked from commit d70ee13)

Co-authored-by: Seth Michael Larson <seth@python.org>

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117951 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label Apr 16, 2024
zooba pushed a commit that referenced this pull request Apr 16, 2024
gh-112844: Fix xz CPE identifier (GH-117656)
d9e2126 
(cherry picked from commit d70ee13)

Co-authored-by: Seth Michael Larson <seth@python.org>

sethmlarson commented Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

Thanks @zooba! 🙏

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-112844: Fix xz CPE identifier (pythonGH-117656)
f539091
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

zooba zooba approved these changes

Assignees

No one assigned

Labels

3.12 only security fixes skip news type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL