FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.12] gh-117114: Update availability and source code link in os.path.rst by nineteendo · Pull Request #117756 · python/cpython · GitHub

/ cpython Public

[3.12] gh-117114: Update availability and source code link in os.path.rst - #117756

Merged
zooba merged 1 commit into
python:3.12from
nineteendo:link-to-genericpath
Apr 15, 2024
ConversationCommits (1)ChecksFiles changed
Merged

[3.12] gh-117114: Update availability and source code link in os.path.rst#117756
zooba merged 1 commit into
python:3.12from
nineteendo:link-to-genericpath

Conversation

nineteendo commented Apr 11, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

I added a link to Lib/genericpath.py in the documentation of os.path (and removed the redundant availability notes) in this pull request: #117115, but this wasn't backported.

Note: the other changes in this pull request are NOT being backported.

📚 Documentation preview 📚: https://cpython-previews--117756.org.readthedocs.build/

bedevere-app Bot added docs Documentation in the Doc dir skip news labels Apr 11, 2024
nineteendo marked this pull request as ready for review April 11, 2024 15:03

nineteendo commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?

erlend-aasland commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?

AFAICS, this belongs to gh-117114.

erlend-aasland changed the title [3.12] Link to genericpath [3.12] gh-117114: Update availability and source code link in os.path.rst Apr 11, 2024
bedevere-app Bot mentioned this pull request Apr 11, 2024
Closed

erlend-aasland commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

Are you sure about those availability adjustments?

nineteendo commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

Yeah, when a function is defined in both Lib/ntpath.py & Lib/posixpath.py, it's available on all platforms.

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it: d7538dd.

nineteendo commented Apr 13, 2024

Copy link
Copy Markdown
Contributor Author

@zooba, thoughts?

nineteendo commented Apr 14, 2024

Copy link
Copy Markdown
Contributor Author

@AlexWaygood, do you have an opinion on this?

zooba commented Apr 15, 2024

Copy link
Copy Markdown
Member

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it

That and probably a few were only available on one, and then when we added the other we added to the list rather than removing the list.

This looks good to me.

zooba merged commit 2dcb267 into python:3.12 Apr 15, 2024
nineteendo deleted the link-to-genericpath branch April 15, 2024 15:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erlend-aasland erlend-aasland approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL