FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file by methane · Pull Request #117802 · python/cpython · GitHub

/ cpython Public

gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file - #117802

Merged
methane merged 4 commits into
python:mainfrom
methane:utf8-pth-file
Apr 16, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-77102: site: try utf-8 and fallback to locale encoding when reading pth file#117802
methane merged 4 commits into
python:mainfrom
methane:utf8-pth-file

Conversation

methane commented Apr 12, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request Apr 12, 2024
Closed
hauntsaninja approved these changes Apr 14, 2024
View reviewed changes

hauntsaninja left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me!

vstinner approved these changes Apr 15, 2024
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

Maybe document the change https://docs.python.org/dev/whatsnew/3.13.html#improved-modules for more visibility.

vstinner approved these changes Apr 15, 2024
View reviewed changes

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

methane merged commit 6dc661b into python:main Apr 16, 2024
methane deleted the utf8-pth-file branch April 16, 2024 03:56

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117917 is a backport of this pull request to the 3.12 branch.

methane added a commit to methane/cpython that referenced this pull request Apr 16, 2024
[3.12] pythongh-77102: site: try utf-8 and fallback to locale encodin…
8f81901 
…g when reading .pth file (pythonGH-117802)

(cherry picked from commit 6dc661b)

Co-authored-by: Inada Naoki <songofacandy@gmail.com>

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117918 is a backport of this pull request to the 3.11 branch.

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117917 is a backport of this pull request to the 3.12 branch.

bedevere-app Bot commented Apr 16, 2024

Copy link
Copy Markdown

GH-117918 is a backport of this pull request to the 3.11 branch.

methane added a commit that referenced this pull request Apr 16, 2024
gh-77102: site: try utf-8 and locale encoding when reading .pth file (G…
2a58923 
…H-117802)

(cherry picked from commit 6dc661b)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
pythongh-77102: site: try utf-8 and fallback to locale encoding when …
b99f984 
…reading .pth file (python#117802)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner vstinner approved these changes
hauntsaninja hauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL