gh-96398: Improve accuracy of compiler checks in configure.ac by erlend-aasland · Pull Request #117815 · python/cpython · GitHub

Some checks require a GCC compatible compiler; use $ac_cv_gcc_compat for these.
Some checks require checking the compiler basename; use $CC_BASENAME for these.
For the rest, use $ac_cv_cc_name.

Issue: configure.ac: using $CC to check compiler names may result in erroneous judgements #96398

…n configure

cc. @ronaldoussoren and @ned-deily

In order to solve the WASI error, I propose to introduce a "GCC compatible" check, and use that as a gate to the compiler flag checks.

UPDATE: proposed in #117825

Introduce a cached variable $ac_cv_gcc_compat and set it to 'yes' if the C preprocessor defines the __GNUC__ macro.

I'm really happy you're taking this on! One inline question:

@igalic: I did not spot the question; did it get lost when you posted the comment?

I'm really happy you're taking this on! One inline question:

@igalic: I did not spot the question; did it get lost when you posted the comment?

a less bleary eyed review reveals that I was reading the LTO code wrong. not sure why my question didn't post at all, tho

This doesn't seem to correspond to the definition of AC_PATH_TOOL:

AC_PATH_TOOL (variable, prog-to-check-for, [value-if-not-found], [path = ‘$PATH’])

variable = CXX
prog-to-check-for = g++
value-if-not-found = g++ (?)
path = notfound (??)

Also, CC_BASENAME may contain a platform triplet, so shouldn't this use ac_cv_cc_name instead?

Also, CC_BASENAME may contain a platform triplet, so shouldn't this use ac_cv_cc_name instead?

Yes, this should use ac_cv_cc_name, not CC_BASENAME.

This doesn't seem to correspond to the definition of AC_PATH_TOOL:

Indeed; I suggest we look at this in a separate PR.

Also, CC_BASENAME may contain a platform triplet, so shouldn't this use ac_cv_cc_name instead?

Addressed with 9900633.

FWIW: @mhsmith pinged me on this PR, because of the potential for clash with the iOS compiler shims (around L400 of configure.ac). I've confirmed that iOS builds still work with these changes.

It seems there are refleaks on main. I'll wait for them to be resolved and do another buildbot run, just to make sure.

In the mean time, feel free to take another look, if needed.

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit d309996 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 9900633 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Heads-up: I plan to merge this within a few days.

Thanks for reviewing, everyone!

…ython#117815) The following variables are now used in compiler checks: - $ac_cv_gcc_compat is set to 'yes' for GCC compatible compilers (the C preprocessor defines the __GNUC__ macro) - for compiler basename checks, use $CC_BASENAME (may contain platform triplets) - for the rest, use $ac_cv_cc_name (does not contain platform triplets)

pythongh-96398 : Consistently use $ac_cv_cc_name for compiler checks i…

4a55006

…n configure

erlend-aasland requested a review from corona10 as a code owner April 12, 2024 12:21

erlend-aasland added the skip news label Apr 12, 2024

bedevere-app Bot added the awaiting core review label Apr 12, 2024

bedevere-app Bot mentioned this pull request Apr 12, 2024

configure.ac: using $CC to check compiler names may result in erroneous judgements #96398

Closed

erlend-aasland commented Apr 12, 2024

View reviewed changes

Comment thread configure.ac

erlend-aasland added 2 commits April 12, 2024 15:09

Bring back the mpicc

3e03fe4

Detect emcc

2305a7b

This comment was marked as outdated.

Sign in to view

Pull in main

444b92d

erlend-aasland marked this pull request as draft April 12, 2024 15:48

bedevere-app Bot removed the awaiting core review label Apr 12, 2024

erlend-aasland mentioned this pull request Apr 12, 2024

gh-96398: Detect GCC compatible compilers in configure #117825

Merged

erlend-aasland added 3 commits April 12, 2024 22:10

pythongh-96398 : Detect GCC compatible compilers in configure

1077ec3

Introduce a cached variable $ac_cv_gcc_compat and set it to 'yes' if the C preprocessor defines the __GNUC__ macro.

Use ac_cv_gcc_compat where possible

aeed46f

Pull in main

cc3731f

erlend-aasland changed the title gh-96398: Consistently use $ac_cv_cc_name for compiler checks in configure gh-96398: Use $ac_cv_cc_name and $ac_cv_gcc_compat in configure compiler checks Apr 12, 2024

erlend-aasland added 3 commits April 12, 2024 22:30

syntax

a614de5

;;

c55d838

regen ac

b249323

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into autoconf/cc

00cb06c

This comment was marked as outdated.

Sign in to view

corona10 reviewed Apr 13, 2024

View reviewed changes

Comment thread configure.ac

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into autoconf/cc

474d5f9

erlend-aasland marked this pull request as ready for review April 13, 2024 21:33

bedevere-app Bot added the awaiting core review label Apr 13, 2024

erlend-aasland changed the title gh-96398: Use $ac_cv_cc_name and $ac_cv_gcc_compat in configure compiler checks gh-96398: More accurate compiler checks in configure.ac Apr 14, 2024

erlend-aasland changed the title gh-96398: More accurate compiler checks in configure.ac gh-96398: Improve accuracy of compiler checks in configure.ac Apr 14, 2024

erlend-aasland requested a review from mhsmith April 15, 2024 21:22

mhsmith reviewed Apr 17, 2024

View reviewed changes

Pull in main

0df909e

erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024

This comment was marked as outdated.

Sign in to view

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 14, 2024

Merge branch 'main' into autoconf/cc

d309996

erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 28, 2024

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 28, 2024

erlend-aasland added 2 commits October 28, 2024 23:06

Pull in main

c6fa062

Address Malcom's review

9900633

erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 29, 2024

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 29, 2024

erlend-aasland mentioned this pull request Nov 5, 2024

Upgrade to GNU Autoconf 2.72 #115765

Closed

2 tasks done

erlend-aasland merged commit a5b94d0 into python:main Nov 7, 2024

erlend-aasland deleted the autoconf/cc branch November 7, 2024 09:50

bedevere-app Bot removed the awaiting core review label Nov 7, 2024

encukou mentioned this pull request Oct 15, 2026

Flaky detection of compiler vendor #83142

Closed

+                      case "$CC_BASENAME" in
                       gcc)    AC_PATH_TOOL([CXX], [g++], [g++], [notfound]) ;;
                       cc)     AC_PATH_TOOL([CXX], [c++], [c++], [notfound]) ;;
-                      clang|*/clang)     AC_PATH_TOOL([CXX], [clang++], [clang++], [notfound]) ;;
-                      icc|*/icc)         AC_PATH_TOOL([CXX], [icpc], [icpc], [notfound]) ;;
+                      clang)             AC_PATH_TOOL([CXX], [clang++], [clang++], [notfound]) ;;
+                      icc)               AC_PATH_TOOL([CXX], [icpc], [icpc], [notfound]) ;;

gh-96398: Improve accuracy of compiler checks in configure.ac by erlend-aasland · Pull Request #117815 · python/cpython · GitHub

Repository navigation

gh-96398: Improve accuracy of compiler checks in configure.ac - #117815

gh-96398: Improve accuracy of compiler checks in configure.ac#117815erlend-aasland merged 20 commits intopython:mainpython/cpython:mainfrom erlend-aasland:autoconf/ccerlend-aasland/cpython:autoconf/ccCopy head branch name to clipboard

Conversation

erlend-aasland commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Apr 12, 2024

Uh oh!

Uh oh!

This comment was marked as outdated.

erlend-aasland commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

erlend-aasland commented Apr 13, 2024

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as resolved.

igalic commented Apr 13, 2024

Uh oh!

mhsmith Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

mhsmith Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

erlend-aasland Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

erlend-aasland Oct 28, 2024

Choose a reason for hiding this comment

Uh oh!

freakboy3742 commented Apr 18, 2024

Uh oh!

This comment was marked as outdated.

erlend-aasland commented Oct 15, 2024

Uh oh!

bedevere-bot commented Oct 28, 2024

Uh oh!

bedevere-bot commented Oct 29, 2024

Uh oh!

erlend-aasland commented Nov 5, 2024

Uh oh!

erlend-aasland commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gh-96398: Improve accuracy of compiler checks in configure.ac#117815
erlend-aasland merged 20 commits into
python:mainfrom
erlend-aasland:autoconf/cc

erlend-aasland commented Apr 12, 2024 •
edited
Loading

erlend-aasland commented Apr 12, 2024 •
edited
Loading