gh-117657: Quiet TSAN warning about a data race between start_the_world() and tstate_try_attach() - #117828
Merged
colesbury merged 2 commits intoApr 15, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…`tstate_try_attach()` TSAN erroneously reports a data race between the `_Py_atomic_compare_exchange_int` on `tstate->state` in `tstate_try_attach()` and the non-atomic load of `tstate->state` in `start_the_world`. The `_Py_atomic_compare_exchange_int` fails, but TSAN erroneously treats it as a store.
colesbury
reviewed
Apr 12, 2024
Comment thread
Python/pystate.c
Outdated
colesbury
approved these changes
Apr 15, 2024
mpage
added a commit
to mpage/cpython
that referenced
this pull request
Apr 16, 2024
The underlying races were fixed in pythongh-117830 and pythongh-117828
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…the_world()` and `tstate_try_attach()` (python#117828) TSAN erroneously reports a data race between the `_Py_atomic_compare_exchange_int` on `tstate->state` in `tstate_try_attach()` and the non-atomic load of `tstate->state` in `start_the_world`. The `_Py_atomic_compare_exchange_int` fails, but TSAN erroneously treats it as a store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TSAN erroneously reports a data race (example) between the _Py_atomic_compare_exchange_int on tstate->state in tstate_try_attach():
cpython/Python/pystate.c
Lines 1993 to 1995 in 069de14
and the non-atomic load of tstate->state in start_the_world():
cpython/Python/pystate.c
Line 2251 in 069de14
The _Py_atomic_compare_exchange_int fails, but TSAN erroneously treats it as a store.