gh-117518: Clarify PyTuple_GetItem() borrowed reference in the doc - #117920
Merged
encukou merged 2 commits intoApr 19, 2024
Merged
gh-117518: Clarify PyTuple_GetItem() borrowed reference in the doc#117920encukou merged 2 commits into
encukou merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
The return value is already emphasised as being a borrowed reference:
It seems a bit strange to repeat this in the text below. Consider just adding the text that suggests the better approach. |
Sorry, something went wrong.
Comment thread
Doc/c-api/tuple.rst
Outdated
Copy link
Copy Markdown
Member
Author
|
@erlend-aasland @encukou: I applied @erlend-aasland's suggestion. |
Sorry, something went wrong.
erlend-aasland
approved these changes
Apr 17, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 19, 2024
…doc (pythonGH-117920) (cherry picked from commit 4605a19) Co-authored-by: Victor Stinner <vstinner@python.org>
Copy link
Copy Markdown
|
GH-118087 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--117920.org.readthedocs.build/