gh-117953: Cleanups For fix_up_extension() in import.c - #118192
Merged
ericsnowcurrently merged 11 commits intoApr 24, 2024
Merged
gh-117953: Cleanups For fix_up_extension() in import.c#118192ericsnowcurrently merged 11 commits into
ericsnowcurrently merged 11 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ericsnowcurrently
requested review from
brettcannon,
kumaraditya303,
ncoghlan and
warsaw
as code owners
April 23, 2024 17:32
ericsnowcurrently
removed request for
brettcannon,
kumaraditya303,
ncoghlan and
warsaw
April 23, 2024 17:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are cleanups I've pulled out of gh-118116. Mostly, this change moves code around to align with some future changes and to improve clarity a little. There is one very small change in behavior: we now add the module to the per-interpreter caches after updating the global state, rather than before.