gh-117657: Fixes a few small TSAN issues in dictobject - #118200
Merged
DinoV merged 2 commits intoApr 25, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
mpage
reviewed
Apr 23, 2024
Comment thread
Tools/tsan/suppressions_free_threading.txt
Copy link
Copy Markdown
Contributor
|
LGTM! |
Sorry, something went wrong.
Keys need atomic relaxed loads as they can be assigned from another thread
Entries need atomic release assigns so the values they point to are seen
Reading managed dict needs acquire so that the memory of a newly created and published dictionary is visible
colesbury
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a few spots in the dict implementation where we're not using atomics to access or update the dictionary size. This updates those so that we're using relaxed atomics on them.
The dictobject.h case is a little special because we don't have the FT macros available, so it's special cased with an ifdef.