gh-117953: Share More Machinery Code Between Builtin and Dynamic Extensions - #118204
Merged
ericsnowcurrently merged 5 commits intoApr 29, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ericsnowcurrently
force-pushed
the
builtins-and-extensions-shared-code
branch
from
32a319a to
6f7a862
Compare
April 24, 2024 21:30
ericsnowcurrently
force-pushed
the
builtins-and-extensions-shared-code
branch
from
9508b74 to
c897f6a
Compare
April 29, 2024 15:32
ericsnowcurrently
marked this pull request as ready for review
April 29, 2024 15:37
ericsnowcurrently
requested review from
brettcannon,
kumaraditya303,
ncoghlan and
warsaw
as code owners
April 29, 2024 15:37
ericsnowcurrently
removed request for
brettcannon,
kumaraditya303,
ncoghlan and
warsaw
April 29, 2024 15:37
ericsnowcurrently
added a commit
that referenced
this pull request
Aug 13, 2024
As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 13, 2024
…h-122952) As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately. (cherry picked from commit ee1b8ce) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…h-122952) As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
Yhg1s
pushed a commit
that referenced
this pull request
Dec 3, 2024
) (#122984) gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952) As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately. (cherry picked from commit ee1b8ce) Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've pulled this out of gh-118116.
This change will make some later changes simpler. It also brings more consistent behavior and lower maintenance costs.