FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118216: Don't consider dotted `__future__` imports by thatbirdguythatuknownot · Pull Request #118267 · python/cpython · GitHub

/ cpython Public

gh-118216: Don't consider dotted __future__ imports - #118267

Merged
JelleZijlstra merged 7 commits into
python:mainfrom
thatbirdguythatuknownot:patch-33
May 2, 2024
ConversationCommits (7)ChecksFiles changed
Merged

gh-118216: Don't consider dotted __future__ imports#118267
JelleZijlstra merged 7 commits into
python:mainfrom
thatbirdguythatuknownot:patch-33

Conversation

thatbirdguythatuknownot commented Apr 25, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Add checking for the number of dots before the module name alongside __future__ name checks in Python/future.c and Python/compile.c. Basically makes a __future__ import only be considered one when no dots are present before the module name.

bedevere-app Bot mentioned this pull request Apr 25, 2024
Closed

nineteendo commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Could you also configure pre-commit? https://devguide.python.org/getting-started/setup-building/#install-pre-commit

Misc/NEWS.d/next/Core and Builtins/2024-04-25-11-48-28.gh-issue-118216.SVg700.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)

JelleZijlstra reviewed May 2, 2024
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks, this looks good. Could you add an entry to the What's New for 3.13? This is arguably a change to the language semantics.

JelleZijlstra self-assigned this May 2, 2024

thatbirdguythatuknownot commented May 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Got it.

JelleZijlstra commented May 2, 2024

Copy link
Copy Markdown
Member

@thatbirdguythatuknownot thanks! One piece of feedback: please avoid force-pushing to a PR branch, as it makes review somewhat harder. Just push a new commit and we'll squash them on merge. To update the PR branch with new commits from main, either click the "Update branch" button in GitHub or run git merge upstream/main (or whatever your remote is called) locally.

JelleZijlstra merged commit 7c97dc8 into python:main May 2, 2024

thatbirdguythatuknownot commented May 2, 2024

Copy link
Copy Markdown
Contributor Author

Okay.

SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
pythongh-118216: Don't consider dotted __future__ imports (python#1…
3a5882a 
…18267)
nineteendo mentioned this pull request Oct 5, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
markshannon Awaiting requested review from markshannon markshannon is a code owner
iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Assignees

JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL