gh-117225: Move colorize functionality to own internal module - #118283
Merged
hugovk merged 5 commits intoMay 1, 2024
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Lib/_colorize.py
Outdated
nineteendo
reviewed
Apr 25, 2024
nineteendo
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Remove these newlines.
Sorry, something went wrong.
Comment thread
Lib/_colorize.py
hugovk
marked this pull request as ready for review
April 29, 2024 21:37
Copy link
Copy Markdown
Member
Author
|
Somehow managed to find two free-threaded bugs with this PR, but they're fixed now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the refactoring postponed from PR #117583.