FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-116749: Disable GIL by default in free-threaded build by colesbury · Pull Request #118295 · python/cpython · GitHub

/ cpython Public

gh-116749: Disable GIL by default in free-threaded build - #118295

Merged
colesbury merged 2 commits into
python:mainfrom
colesbury:gh-116749-disable-gil
Apr 26, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-116749: Disable GIL by default in free-threaded build#118295
colesbury merged 2 commits into
python:mainfrom
colesbury:gh-116749-disable-gil

Conversation

colesbury commented Apr 25, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Switch GIL to disabled by default in free-threaded build so that the free-threaded CIs catch thread-safety issues.

pythongh-116749: Disable GIL by default in free-threaded build
9fc88f4 
Switch GIL to disabled by default in free-threaded build so that the
free-threaded CIs catch thread-safety issues.

colesbury commented Apr 25, 2024

Copy link
Copy Markdown
Contributor Author

!buildbot nogil

bedevere-app Bot mentioned this pull request Apr 25, 2024
Closed

bedevere-bot commented Apr 25, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9fc88f4 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel NoGIL PR

colesbury requested review from DinoV and swtaarrs April 26, 2024 15:04
colesbury marked this pull request as ready for review April 26, 2024 15:04
SonicField approved these changes Apr 26, 2024
View reviewed changes

SonicField left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

swtaarrs reviewed Apr 26, 2024
View reviewed changes
Comment thread Python/initconfig.c Outdated
DinoV approved these changes Apr 26, 2024
View reviewed changes

DinoV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sweet!!

swtaarrs approved these changes Apr 26, 2024
View reviewed changes

swtaarrs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Exciting 😃

colesbury merged commit 5a90de0 into python:main Apr 26, 2024
colesbury deleted the gh-116749-disable-gil branch April 26, 2024 18:22
colesbury mentioned this pull request Apr 26, 2024
Closed

corona10 commented Apr 26, 2024

Copy link
Copy Markdown
Member

Historical moment!

cychen2021 commented Apr 27, 2024

Copy link
Copy Markdown

Cool!

swtaarrs mentioned this pull request Apr 30, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

swtaarrs swtaarrs approved these changes
DinoV DinoV approved these changes
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
+1 more reviewer
SonicField SonicField approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL