gh-117657: Disable the function/code cache in free-threaded builds - #118301
Merged
colesbury merged 3 commits intoMay 3, 2024
Merged
gh-117657: Disable the function/code cache in free-threaded builds#118301colesbury merged 3 commits into
colesbury merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This is only used by the specializing interpreter and the tier 2 optimizer, both of which are disabled in free-threaded builds. [Sample race](https://gist.github.com/mpage/d05a1c4616eedc9337f3f335e6485f91) that is fixed.
colesbury
approved these changes
May 2, 2024
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…lds (python#118301) This is only used by the specializing interpreter and the tier 2 optimizer, both of which are disabled in free-threaded builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only used by the specializing interpreter and the tier 2 optimizer, both of which are disabled in free-threaded builds.
Additionally, make function version generation thread-safe in free-threaded builds. I don't think anything outside of the specializing interpreter / tier 2 optimizer actually uses this, so we could allow version generation to race if we're concerned about introducing a bottleneck with the lock.
Sample race that is fixed.