FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118318: Remove outdated c14n references from ElementTree by danifus · Pull Request #118319 · python/cpython · GitHub

Repository navigation

gh-118318: Remove outdated c14n references from ElementTree - #118319

Merged
serhiy-storchaka merged 5 commits into
python:mainfrom
danifus:cleanup-removed-c14n
Aug 9, 2026
Merged

serhiy-storchaka merged 5 commits into
python:mainfrom
danifus:cleanup-removed-c14n

Conversation

danifus commented Apr 26, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Some references to a removed c14n serialization method remained in ElementTree.py. Attempting to use method='c14n' in the write() method would result in ValueError: unknown method 'c14n'.

Removes the write_c14n() method that uses method='c14n' and also raises the same error.

Some references to a removed `c14n` serialization method remained in
ElementTree.py. Attempting to use `method='c14n'` in the `write()`
method would result in `ValueError: unknown method 'c14n'`.

Removes the `write_c14n()` method that uses `method='c14n'` and also
raises the same error.

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 16, 2026

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add a NEWS entry and a What's New entry for this change.

Comment thread Lib/xml/etree/ElementTree.py Outdated

bedevere-app Bot commented May 25, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 30, 2026

serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added NEWS and What's NEW. LGTM now.

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33983594 | 📁 Comparing f40f26a against main (5107fd7)

  🔍 Preview build  

2 files changed
± whatsnew/3.16.html
± whatsnew/changelog.html

serhiy-storchaka enabled auto-merge (squash) August 9, 2026 20:35
serhiy-storchaka merged commit 87b120f into python:main Aug 9, 2026
99 of 102 checks passed
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
…thonGH-118319)

Some references to a removed `c14n` serialization method remained in
ElementTree.py. Attempting to use `method='c14n'` in the `write()`
method would result in `ValueError: unknown method 'c14n'`.

Removes the `write_c14n()` method that uses `method='c14n'` and also
raises the same error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL