FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-109975: Document crypt_r as a possible replacement of crypt by hroncok · Pull Request #118439 · python/cpython · GitHub

/ cpython Public

gh-109975: Document crypt_r as a possible replacement of crypt - #118439

Merged
hugovk merged 1 commit into
python:mainfrom
hroncok:crypt_r
Apr 30, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-109975: Document crypt_r as a possible replacement of crypt#118439
hugovk merged 1 commit into
python:mainfrom
hroncok:crypt_r

Conversation

hroncok commented Apr 30, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot mentioned this pull request Apr 30, 2024
Closed
bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Apr 30, 2024

nineteendo commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

It's worth mentioning you're the author of the crypt_r module.

hroncok commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

I am not the author (it's dissected from CPython 3.12, authored by others), but I am indeed a maintainer. Other modules in the list do not have their authors/maintainers mentioned. Should I put a disclaimer to the commit message?

nineteendo commented Apr 30, 2024

Copy link
Copy Markdown
Contributor

No, I just meant for the pull request, as you're kind of advertising the module.

hugovk approved these changes Apr 30, 2024
View reviewed changes

hugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Duly noted @hroncok is a maintainer, thank you for creating the package and for this PR.

Perhaps drop a note at https://discuss.python.org/t/pep-594-has-been-implemented-python-3-13-removes-20-stdlib-modules/27124 as well?

hugovk merged commit f7747f7 into python:main Apr 30, 2024

hroncok commented Apr 30, 2024

Copy link
Copy Markdown
Contributor Author

Perhaps drop a note at https://discuss.python.org/t/pep-594-has-been-implemented-python-3-13-removes-20-stdlib-modules/27124 as well?

https://discuss.python.org/t/pep-594-has-been-implemented-python-3-13-removes-20-stdlib-modules/27124/14

hroncok deleted the crypt_r branch April 30, 2024 23:28
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
pythongh-109975: Document crypt_r as a possible replacement of crypt (p…
033f9cc 
…ython#118439)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

hugovk hugovk approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL