gh-117657: Use clang 18 in TSAN builds - #118533
Merged
encukou merged 1 commit intoMay 7, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We were using clang 14 which is a couple of years old.
Copy link
Copy Markdown
Contributor
|
Does the version matter? I've been using gcc 11.4 locally and haven't run into issues yet. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
The main motivation is that we get a newer llvm-symbolizer for use in TSAN, which gives us (slightly) more helpful error messages. For example, instead of LLVMSymbolizer: error reading file: No such file or directory we get /usr/bin/llvm-symbolizer-18: error: '[stack]': No such file or directory |
Sorry, something went wrong.
colesbury
approved these changes
May 3, 2024
corona10
approved these changes
May 4, 2024
corona10
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I hope apt.llvm.org won't go down as often as Launchpad :) |
Sorry, something went wrong.
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Use clang 18 in TSAN builds We were using clang 14 which is a couple of years old.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using clang 14 which is a couple of years old.