FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118251: Skip tests not files in JIT CI by savannahostrowski · Pull Request #118536 · python/cpython · GitHub

/ cpython Public

gh-118251: Skip tests not files in JIT CI - #118536

Merged
brandtbucher merged 4 commits into
python:mainfrom
savannahostrowski:jit-skip-tests-ci
May 3, 2024
ConversationCommits (4)ChecksFiles changed
Merged

gh-118251: Skip tests not files in JIT CI#118536
brandtbucher merged 4 commits into
python:mainfrom
savannahostrowski:jit-skip-tests-ci

Conversation

savannahostrowski commented May 3, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

This PR moves jit.yml to reference an ignorefile as opposed to skipping entire files in CI.

Notes:

  • test_multiprocessing_fork - had to be wholly skipped to get things to pass
  • I am very flexible on file name and location. I dropped the ignorefile in Tools/jit for now since it was easier to deal with while testing since that dir is tracked in the workflow file. Happy to move it elsewhere if it makes more sense (e.g. in .github/workflows)
  • I also removed the exclude arg from other architectures since they aren't needed/being used.

bedevere-app Bot mentioned this pull request May 3, 2024
Closed
savannahostrowski changed the title gh-118251: Skip tests when running JIT CI gh-118251: Skip tests not files in JIT CI May 3, 2024
brandtbucher reviewed May 3, 2024
View reviewed changes

brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks a ton, this really increases our test coverage for these builds! I'm happy keeping the file with the rest of the JIT stuff.

Can you also remove the --exclude from the Native Windows job? GitHub won't let me comment outside of the diff.

Comment thread .github/workflows/jit.yml Outdated
brandtbucher self-assigned this May 3, 2024
brandtbucher added tests Tests in the Lib/test dir skip news labels May 3, 2024
brandtbucher enabled auto-merge (squash) May 3, 2024 18:53
brandtbucher disabled auto-merge May 3, 2024 18:54
brandtbucher enabled auto-merge (squash) May 3, 2024 18:54
brandtbucher merged commit 5248596 into python:main May 3, 2024
This was referenced May 3, 2024
Merged
Merged
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
pythonGH-118251: Skip fewer test in emulated JIT CI (pythonGH-118536)
4670d66
savannahostrowski deleted the jit-skip-tests-ci branch September 27, 2024 16:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brandtbucher brandtbucher approved these changes

Assignees

brandtbucher

Labels

skip news tests Tests in the Lib/test dir topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL