gh-117549: Don't use designated initializers in headers - #118580
Conversation
Sorry, something went wrong.
scoder
left a comment
There was a problem hiding this comment.
The change looks reasonable to me and should resolve the issue. I couldn't test it because so far I found the problem only with MSVC and I don't have MSVC to test locally. Compiling CPython main with this patch on Linux with g++ and testing it there worked ok for me. Regarding performance, any C/C++ compiler that fails to alias the inlined function call and its return value into a plain value here should blush and rub its face in dirt.
Sorry, something went wrong.
|
Thanks for the quick response, I appreciate it. |
Sorry, something went wrong.
|
Benchmarks show nothing unexpected. I'll merge now. |
Sorry, something went wrong.
…#118580) The designated initializer syntax in static inline functions in pycore_backoff.h causes problems for C++ or MSVC users who aren't yet using C++20. While internal, pycore_backoff.h is included (indirectly, via pycore_code.h) by some key 3rd party software that does so for speed.
Apparently in C++ this requires a recent standard version (C++20) and not everyone can switch to that yet. And this header, while internal, is included (possibly indirectly, via pycore_code.h) by some key 3rd party software that does so for speed, and we don't want to require folks to upgrade their C++ standard version when upgrading to Python 3.13.
NOTE: Before merging this I want to double-check that it doesn't slow things down. I'll start a benchmark run on our internal benchmark infrastructure.