FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118518: Use the raw syscall directly for gettid by pablogsal · Pull Request #118592 · python/cpython · GitHub

/ cpython Public

gh-118518: Use the raw syscall directly for gettid - #118592

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gettid
May 5, 2024
ConversationCommits (1)ChecksFiles changed
Merged

gh-118518: Use the raw syscall directly for gettid#118592
pablogsal merged 1 commit into
python:mainfrom
pablogsal:gettid

Conversation

pablogsal commented May 5, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

pablogsal requested a review from brandtbucher as a code owner May 5, 2024 09:51
bedevere-app Bot mentioned this pull request May 5, 2024
Closed
pablogsal mentioned this pull request May 5, 2024
Merged

pablogsal commented May 5, 2024

Copy link
Copy Markdown
Member Author

!buildbot AMD64 RHEL8

bedevere-bot commented May 5, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit a08d6b4 🤖

The command will test the builders whose names match following regular expression: AMD64 RHEL8

The builders matched are:

  • AMD64 RHEL8 LTO PR
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 RHEL8 FIPS No Builtin Hashes PR
  • AMD64 RHEL8 PR
  • AMD64 RHEL8 Refleaks PR
  • AMD64 RHEL8 LTO + PGO PR

pablogsal enabled auto-merge (squash) May 5, 2024 10:26
pablogsal merged commit aeb36c5 into python:main May 5, 2024
pablogsal deleted the gettid branch May 5, 2024 12:37
ericsnowcurrently reviewed May 6, 2024
View reviewed changes
Comment thread Python/perf_jit_trampoline.c
ev.base.time_stamp = get_current_monotonic_ticks();
ev.process_id = getpid();
ev.thread_id = gettid();
ev.thread_id = syscall(SYS_gettid);

ericsnowcurrently May 6, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps it would make sense to leverage the existing thread API, e.g. PyThread_get_thread_native_id()?

pablogsal May 6, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I did that first but that has a check first for !initialized that calls PyThread_init_thread and that was causing problems when fork happens.

SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
pythongh-118518: Use the raw syscall directly for gettid (python#118592)
cb20391
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently ericsnowcurrently left review comments
brandtbucher Awaiting requested review from brandtbucher

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL