gh-118518: Rename PYTHONPERFJITSUPPORT and -X perfjit with underscores - #118693
Merged
pablogsal merged 2 commits intoMay 7, 2024
Merged
gh-118518: Rename PYTHONPERFJITSUPPORT and -X perfjit with underscores#118693pablogsal merged 2 commits into
pablogsal merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hugovk
force-pushed
the
PYTHON_PERF_JIT_SUPPORT
branch
from
13f27bb to
54db163
Compare
May 7, 2024 09:53
pablogsal
approved these changes
May 7, 2024
pablogsal
enabled auto-merge (squash)
May 7, 2024 10:35
Copy link
Copy Markdown
Member
Author
|
The TSAN job timed out: https://github.com/python/cpython/actions/runs/8983317059/job/24672835971?pr=118693 I've restarted it. |
Sorry, something went wrong.
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…underscores (python#118693)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames:
From Python 3.13, new environment variables should use underscores:
I don't think we have a policy for -X options, and we have a mix (I think newer ones tend to use underscores?), but I recommend using an underscore here too for the same accessibility and readability reasons as env vars. Plus consistency with the env var.
For example, we added PYTHON_CPU_COUNT and -X cpu_count in 3.13.
cc @pablogsal
📚 Documentation preview 📚: https://cpython-previews--118693.org.readthedocs.build/