FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) by vstinner · Pull Request #11870 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) - #11870

Merged
larryhastings merged 3 commits into
python:3.4from
vstinner:pickle_load34
Feb 25, 2019
ConversationCommits (3)ChecksFiles changed
Merged

[3.4] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261)#11870
larryhastings merged 3 commits into
python:3.4from
vstinner:pickle_load34

Conversation

vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

(cherry picked from commit a4ae828)

https://bugs.python.org/issue34656

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

Please double-check this one, I had to fix compilation error on Windows (second commit). cc @mcepl

mcepl commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

Can you please officially "approve" the change?

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

AppVeyor build succeeded

Aha, my 2nd commit fixed compilation on Windows (and tests pass).

mcepl commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Yeah, it looks sensible. I had the same problem with Windows compilers myself many times. +1 from me.

Can you please officially "approve" the change?

I don't see the button anywhere. I don't think I have any bits required.

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

I don't see the button anywhere. I don't think I have any bits required.

Anyone can approve/reject a change: go to the "Files changes" tab and click on [Review changes] button, then select (o) Approve.

mcepl approved these changes Feb 15, 2019
View reviewed changes

mcepl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is basically my original patch (which is running in openSUSE) with additional fixes for Windows compilation. Looks good.

mcepl commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Like this?

vstinner commented Feb 15, 2019

Copy link
Copy Markdown
Member Author

Like this?

Yes! Thanks :-)

larryhastings merged commit 4b42d57 into python:3.4 Feb 25, 2019

bedevere-bot commented Feb 25, 2019

Copy link
Copy Markdown

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

larryhastings commented Feb 25, 2019

Copy link
Copy Markdown
Contributor

Thanks for the backport!

vstinner deleted the pickle_load34 branch April 29, 2019 14:01
httpsgithubcomxcainiao mannequin mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes
+1 more reviewer
mcepl mcepl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL