FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118760: Restore the default value of tkinter.wantobjects to 1 by serhiy-storchaka · Pull Request #118784 · python/cpython · GitHub

/ cpython Public

gh-118760: Restore the default value of tkinter.wantobjects to 1 - #118784

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:tkinter-wantobject-1
May 20, 2024
ConversationCommits (2)ChecksFiles changed
Merged

gh-118760: Restore the default value of tkinter.wantobjects to 1#118784
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:tkinter-wantobject-1

Conversation

serhiy-storchaka commented May 8, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 8, 2024
Closed
Eclips4 changed the title gh-118760: Restore the default value of tkiter.wantobjects to 1 gh-118760: Restore the default value of tkinter.wantobjects to 1 May 8, 2024
terryjreedy reviewed May 8, 2024
View reviewed changes
Comment thread Misc/NEWS.d/3.13.0b1.rst Outdated
Add support for passing arguments to callbacks registered in the :mod:`tkinter`
module as various Python objects (``int``, ``float``, ``bytes``, ``tuple``),
corresponding to the original Tcl value, not just ``str``, and enable this by default.
To restore the previous behavior set :mod:`!tkinter` module global

terryjreedy May 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This does not make sense when the value already is 1.

serhiy-storchaka May 8, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It is an edited NEWS entry for 3.13.0b1.

terryjreedy May 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The change to 3.13 what's new suggests that the change to wantobjects will be backported also. 'Restoring' 1 to 1 is what I questioned.

serhiy-storchaka May 15, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is an edited NEWS entry for 3.13.0b1. We cannot simply remove it, because it is the part of the history, and 3.13.0b1 was already released with the bug.

But I reworded it, focusing on the possibility to change the behavior and adding that it was changed by default (not for long, for 3.13.0b1 only). So "restoring" here refers to the changed default. How to write this better? Maybe just remove all starting from "To restore"? And add the description of how to enable the experimental feature in the new NEWS entry for 3.13.0b2?

serhiy-storchaka merged commit e188527 into python:main May 20, 2024

miss-islington-app Bot commented May 20, 2024

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

serhiy-storchaka deleted the tkinter-wantobject-1 branch May 20, 2024 19:21
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2024
pythongh-118760: Restore the default value of tkinter.wantobjects to 1 (
1b00598 
pythonGH-118784)

It was set to 2 in 65f5e58 (pythonGH-98592).
(cherry picked from commit e188527)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

bedevere-app Bot commented May 20, 2024

Copy link
Copy Markdown

GH-119251 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 20, 2024
serhiy-storchaka added a commit that referenced this pull request May 20, 2024
[3.13] gh-118760: Restore the default value of tkinter.wantobjects to…
b4462aa 
… 1 (GH-118784) (GH-119251)

It was set to 2 in 65f5e58 (GH-98592).
(cherry picked from commit e188527)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
pythongh-118760: Restore the default value of tkinter.wantobjects to 1 (
6b5ad2c 
pythonGH-118784)

It was set to 2 in 65f5e58 (pythonGH-98592).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

terryjreedy terryjreedy left review comments

Assignees

No one assigned

Labels

release-blocker

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL