FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Docs: fix typos in documentation by xyb · Pull Request #118815 · python/cpython · GitHub

/ cpython Public

Docs: fix typos in documentation - #118815

Merged
vsajip merged 1 commit into
python:mainfrom
xyb:fixtypos
May 10, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Docs: fix typos in documentation#118815
vsajip merged 1 commit into
python:mainfrom
xyb:fixtypos

Conversation

xyb commented May 9, 2024 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels May 9, 2024
vsajip requested changes May 9, 2024
View reviewed changes

vsajip left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The other changes look fine to me.

Comment thread Doc/library/bz2.rst Outdated
Comment thread Doc/library/bz2.rst Outdated

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Privat33r-dev suggested changes May 9, 2024
View reviewed changes

Privat33r-dev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please, revert the latin changes as suggested. Other changes are good, thank you for your contribution.

Comment thread Doc/library/bz2.rst Outdated
Comment thread Doc/library/bz2.rst Outdated

xyb commented May 10, 2024

Copy link
Copy Markdown
Contributor Author

@vsajip @Privat33r-dev Thank you for your advices. I have made the requested changes; please review again.

bedevere-app Bot commented May 10, 2024

Copy link
Copy Markdown

Thanks for making the requested changes!

@vsajip: please review the changes made to this pull request.

bedevere-app Bot requested a review from vsajip May 10, 2024 03:34
vsajip merged commit 17a2cc1 into python:main May 10, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
Docs: fix typos in documentation (pythonGH-118815)
6502eb3
xyb deleted the fixtypos branch May 10, 2024 10:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vsajip vsajip approved these changes
brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
+1 more reviewer
Privat33r-dev Privat33r-dev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL