FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-118817: Fix `asyncio REPL` on Windows by Eclips4 · Pull Request #118819 · python/cpython · GitHub

/ cpython Public

gh-118817: Fix asyncio REPL on Windows - #118819

Merged
gvanrossum merged 3 commits into
python:mainfrom
Eclips4:fix-asyncio-repl
May 9, 2024
ConversationCommits (3)ChecksFiles changed
Merged

gh-118817: Fix asyncio REPL on Windows#118819
gvanrossum merged 3 commits into
python:mainfrom
Eclips4:fix-asyncio-repl

Conversation

Eclips4 commented May 9, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

bedevere-app Bot mentioned this pull request May 9, 2024
Closed
Eclips4 commented May 9, 2024
View reviewed changes
Comment thread Lib/test/test_repl.py
Eclips4 added 3.13 bugs and security fixes needs backport to 3.13 bugs and security fixes and removed 3.13 bugs and security fixes labels May 9, 2024
sobolevn approved these changes May 9, 2024
View reviewed changes

sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good enough for me!

CC @ambv

gvanrossum approved these changes May 9, 2024
View reviewed changes

gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me.

gvanrossum merged commit c3643a1 into python:main May 9, 2024

miss-islington-app Bot commented May 9, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Eclips4 deleted the fix-asyncio-repl branch May 9, 2024 15:20
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2024
pythongh-118817: Fix asyncio REPL on Windows (pythonGH-118819)
89cc421 
(cherry picked from commit c3643a1)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

GH-118847 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 9, 2024
gvanrossum pushed a commit that referenced this pull request May 9, 2024
[3.13] gh-118817: Fix asyncio REPL on Windows (GH-118819) (#118847)
738877a 
(cherry picked from commit c3643a1)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 10, 2024
pythongh-118817: Fix asyncio REPL on Windows (python#118819)
ec921f7
ambv added the topic-repl Related to the interactive shell label May 23, 2024
JelleZijlstra mentioned this pull request May 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gvanrossum gvanrossum approved these changes
sobolevn sobolevn approved these changes
willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

skip news topic-repl Related to the interactive shell

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL