gh-118824: Remove deprecated master_open and slave_open from pty - #118826
Merged
sobolevn merged 5 commits intoMay 28, 2024
Merged
gh-118824: Remove deprecated master_open and slave_open from pty#118826sobolevn merged 5 commits into
sobolevn merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Comment thread
Lib/pty.py
hugovk
reviewed
May 9, 2024
Comment thread
Doc/whatsnew/3.14.rst
Outdated
hugovk
reviewed
May 26, 2024
Comment thread
Doc/whatsnew/3.14.rst
Outdated
Comment thread
Misc/NEWS.d/next/Library/2024-05-09-11-50-26.gh-issue-118824.-jBJQC.rst
Outdated
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk
approved these changes
May 28, 2024
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
🧹
Sorry, something went wrong.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…m `pty` (python#118826) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
ambv
reviewed
Sep 24, 2024
Comment thread
Lib/pty.py
| except ImportError: | ||
| return master_fd, slave_fd | ||
| try: | ||
| ioctl(result, I_PUSH, "ptem") |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
result is a NameError now.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Addressed in #124406
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @gpshead who reviewed #92365
📚 Documentation preview 📚: https://cpython-previews--118826.org.readthedocs.build/