gh-118849: Fix "code will never be executed" warning in dictobject.c - #118850
Merged
sobolevn merged 2 commits intoMay 9, 2024
Merged
gh-118849: Fix "code will never be executed" warning in dictobject.c#118850sobolevn merged 2 commits into
sobolevn merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
colesbury
reviewed
May 9, 2024
Comment thread
Objects/dictobject.c
Outdated
colesbury
approved these changes
May 9, 2024
Copy link
Copy Markdown
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2024
…ject.c` (pythonGH-118850) (cherry picked from commit 82abe75) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Copy link
Copy Markdown
|
GH-118859 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Thanks for the good catch and for the review! :) |
Sorry, something went wrong.
sobolevn
added a commit
that referenced
this pull request
May 9, 2024
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #115108