gh-118846: Fix PGO tests in free-threaded build - #118862
Merged
colesbury merged 1 commit intoMay 9, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Avoid immortalizing objects in some tests that test behavior of collecting classes or modules. This fixes test_ordered_dict and test_struct.
Copy link
Copy Markdown
Contributor
Author
|
cc @hroncok - I'll look at the other tests next, but this should be enough to fix the PGO build. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Indeed it is. Thanks. |
Sorry, something went wrong.
hroncok
approved these changes
May 9, 2024
DinoV
approved these changes
May 9, 2024
DinoV
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Copy link
Copy Markdown
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2024
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct. (cherry picked from commit 1b1db2f) Co-authored-by: Sam Gross <colesbury@gmail.com>
Copy link
Copy Markdown
|
GH-118867 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 10, 2024
Avoid immortalizing objects in tests that verify garbage collection of classes or modules. This fixes test_ordered_dict and test_struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid immortalizing objects in tests that verify garbage collection of classes or modules.
This fixes test_ordered_dict and test_struct.