FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-36007: Bump minimum sphinx version to 1.8 by asottile · Pull Request #11887 · python/cpython · GitHub

/ cpython Public

bpo-36007: Bump minimum sphinx version to 1.8 - #11887

Merged
miss-islington merged 1 commit into
python:masterfrom
asottile:bump_sphinx_36007
Feb 15, 2019
ConversationCommits (1)ChecksFiles changed
Merged

bpo-36007: Bump minimum sphinx version to 1.8#11887
miss-islington merged 1 commit into
python:masterfrom
asottile:bump_sphinx_36007

Conversation

asottile commented Feb 15, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Mariatta approved these changes Feb 15, 2019
View reviewed changes

Mariatta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the quick fix!

miss-islington merged commit a16ab00 into python:master Feb 15, 2019

miss-islington commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Thanks @asottile for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington commented Feb 15, 2019

Copy link
Copy Markdown
Contributor

Sorry, @asottile, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a16ab00c0b8e126ab82e7cb5098af3ea32d315ff 3.7

miss-islington self-assigned this Feb 15, 2019
asottile deleted the bump_sphinx_36007 branch February 15, 2019 23:45

asottile commented Feb 15, 2019

Copy link
Copy Markdown
Contributor Author

@Mariatta I don't think this needs / should be backported to 3.7 -- the :skipif: patch wasn't afaict

Mariatta commented Feb 15, 2019

Copy link
Copy Markdown
Member

Ah you're right. Not sure why I thought it needs a backport. In that case, we're done here.
Thanks again!

AA-Turner mentioned this pull request Oct 19, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Mariatta Mariatta approved these changes

Assignees

miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL