FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Rename `notimplemented_methods` into `nodefault_methods` by sobolevn · Pull Request #118896 · python/cpython · GitHub

/ cpython Public

Rename notimplemented_methods into nodefault_methods - #118896

Merged
sobolevn merged 1 commit into
python:mainfrom
sobolevn:rename-nodefault-methods
May 10, 2024
ConversationCommits (1)ChecksFiles changed
Merged

Rename notimplemented_methods into nodefault_methods#118896
sobolevn merged 1 commit into
python:mainfrom
sobolevn:rename-nodefault-methods

Conversation

sobolevn commented May 10, 2024

Copy link
Copy Markdown
Member

This naming is probably a left-over from copy-pasting the NotImplemented implementation. It should be fixed.

sobolevn requested a review from JelleZijlstra May 10, 2024 12:24
sobolevn requested a review from markshannon as a code owner May 10, 2024 12:24
JelleZijlstra approved these changes May 10, 2024
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oops, thanks. Let's backport this in case we need to tweak the implementation of NoDefault more.

JelleZijlstra added the needs backport to 3.13 bugs and security fixes label May 10, 2024
sobolevn enabled auto-merge (squash) May 10, 2024 12:40
sobolevn merged commit 004db21 into python:main May 10, 2024

miss-islington-app Bot commented May 10, 2024

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2024
Rename notimplemented_methods into nodefault_methods (pythonGH-11…
96d2fc3 
…8896)

(cherry picked from commit 004db21)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

bedevere-app Bot commented May 10, 2024

Copy link
Copy Markdown

GH-118898 is a backport of this pull request to the 3.13 branch.

bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 10, 2024
sobolevn added a commit that referenced this pull request May 10, 2024
[3.13] Rename notimplemented_methods into nodefault_methods (GH-1…
93fce2d 
…18896) (#118898)

Rename `notimplemented_methods` into `nodefault_methods` (GH-118896)
(cherry picked from commit 004db21)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
JelleZijlstra mentioned this pull request May 28, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
AlexWaygood AlexWaygood approved these changes
markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL