gh-118844: Fix --disable-gil & --enable-experimental-jit fails to build - #118935
Merged
brandtbucher merged 5 commits intoMay 11, 2024
Merged
gh-118844: Fix --disable-gil & --enable-experimental-jit fails to build#118935brandtbucher merged 5 commits into
brandtbucher merged 5 commits into
Conversation
Copy link
Copy Markdown
Member
Author
|
Also, make patchcheck fixed up a couple formatting issues in files? Not sure that the one in the trampoline file is desirable? |
Sorry, something went wrong.
brandtbucher
approved these changes
May 11, 2024
brandtbucher
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks! Pretty cool to see these features being used together.
Sorry, something went wrong.
Comment thread
Python/perf_jit_trampoline.c
Outdated
Copy link
Copy Markdown
Member
|
Can you add a NEWS entry, too? |
Sorry, something went wrong.
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Comment thread
Misc/NEWS.d/next/Core and Builtins/2024-05-11-21-44-17.gh-issue-118844.q2H_km.rst
Outdated
…e-118844.q2H_km.rst Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
Copy link
Copy Markdown
|
Thanks @savannahostrowski for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2024
… --enable-experimental-jit (pythonGH-118935) (cherry picked from commit 5b941e5) Co-authored-by: Savannah Ostrowski <savannahostrowski@gmail.com>
Copy link
Copy Markdown
|
GH-118959 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
11 tasks
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
… --enable-experimental-jit (pythonGH-118935)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.